branch-4.1: [improvement](iceberg) Reconstruct partition spec in SHOW CREATE TABLE for Iceberg tables #63240#63372
Open
github-actions[bot] wants to merge 1 commit into
Open
Conversation
…E for Iceberg tables (#63240) ### What problem does this PR solve? Problem Summary: `SHOW CREATE TABLE` for Iceberg external tables omitted the `PARTITION BY LIST (...) ()` clause entirely. The generated DDL was not reproducible — running it as a new `CREATE TABLE` would create an unpartitioned table, silently losing the partition strategy. `Env.getDdlStmt()` for `ICEBERG_EXTERNAL_TABLE` reconstructed `ORDER BY` and `LOCATION` from Iceberg metadata but had no code path for the partition spec. Added `getPartitionSpecSql()` to `IcebergExternalTable`, which reads the live `PartitionSpec` from the Iceberg catalog and converts each `PartitionField` back to Doris DDL syntax. Wired into `Env.getDdlStmt()` between `ORDER BY` and `LOCATION`. *Transform mapping* (all Iceberg standard transforms covered): - isIdentity() → col - isBucket(n) → BUCKET(n, col) - toString() = "truncate[n]" → TRUNCATE(n, col) - toString() = "year/month/day/hour" → YEAR/MONTH/DAY/HOUR(col) - isVoid() → skipped (dropped partition field from evolution) Uses `isVoid()` and `isIdentity()` from the public `Transform` interface where available, falls back to the spec-defined canonical `toString()` names for remaining transforms (stable across all Iceberg versions as they are used in metadata serialisation). Co-authored-by: Sivarajan Narayanan <narayanan_sivarajan@apple.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #63240