Skip to content

branch-4.1: [improvement](iceberg) Reconstruct partition spec in SHOW CREATE TABLE for Iceberg tables #63240#63372

Open
github-actions[bot] wants to merge 1 commit into
branch-4.1from
auto-pick-63240-branch-4.1
Open

branch-4.1: [improvement](iceberg) Reconstruct partition spec in SHOW CREATE TABLE for Iceberg tables #63240#63372
github-actions[bot] wants to merge 1 commit into
branch-4.1from
auto-pick-63240-branch-4.1

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Cherry-picked from #63240

…E for Iceberg tables (#63240)

### What problem does this PR solve?

Problem Summary:

`SHOW CREATE TABLE` for Iceberg external tables omitted the `PARTITION
BY LIST (...) ()` clause entirely. The generated DDL was not
reproducible — running it as a new `CREATE TABLE` would create an
unpartitioned table, silently losing the partition strategy.

`Env.getDdlStmt()` for `ICEBERG_EXTERNAL_TABLE` reconstructed `ORDER BY`
and `LOCATION` from Iceberg metadata but had no code path for the
partition spec.
  
Added `getPartitionSpecSql()` to `IcebergExternalTable`, which reads the
live `PartitionSpec` from the Iceberg catalog and converts each
`PartitionField` back to Doris DDL syntax. Wired into `Env.getDdlStmt()`
between `ORDER BY` and `LOCATION`.

*Transform mapping* (all Iceberg standard transforms covered):
  -  isIdentity() → col
  -  isBucket(n) → BUCKET(n, col)
  -  toString() = "truncate[n]" → TRUNCATE(n, col)
  -  toString() = "year/month/day/hour" → YEAR/MONTH/DAY/HOUR(col)
  -  isVoid() → skipped (dropped partition field from evolution)

Uses `isVoid()` and `isIdentity()` from the public `Transform` interface
where available, falls back to the spec-defined canonical `toString()`
names for remaining transforms (stable across all Iceberg versions as
they are used in metadata serialisation).


Co-authored-by: Sivarajan Narayanan <narayanan_sivarajan@apple.com>
@github-actions github-actions Bot requested a review from yiguolei as a code owner May 18, 2026 21:42
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen
Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 77.27% (34/44) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/44) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants